From: Sahitya Chandra <sahityajb@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Sahitya Chandra <sahityajb@gmail.com>
Subject: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
Date: Sun, 8 Mar 2026 19:58:06 +0530
Message-ID: <20260308142806.181309-1-sahityajb@gmail.com> (raw)
Hi,
While reading the subscription code I noticed one error message that doesn't follow the project's style: in check_remote_recovery_state() in subscriptioncmds.c, the errmsg() for the "publisher is in recovery" case ends with a period. The convention elsewhere (including the similar message a few lines above in the same file) is no trailing period.
The attached one-line patch removes the trailing period from that string. No behavior change.
Thanks,
Sahitya Chandra
---
src/backend/commands/subscriptioncmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
inline patch 1: src/backend/commands/subscriptioncmds.c (+1/-1 lines) download inline-1.patchdiff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.cindex 9e21d7a7df9..724637cff5b 100644--- a/src/backend/commands/subscriptioncmds.c+++ b/src/backend/commands/subscriptioncmds.c@@ -2993,7 +2993,7 @@ check_pub_dead_tuple_retention(WalReceiverConn *wrconn)
if (remote_in_recovery)
ereport(ERROR,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
- errmsg("cannot enable retain_dead_tuples if the publisher is in recovery."));+ errmsg("cannot enable retain_dead_tuples if the publisher is in recovery"));
ExecDropSingleTupleTableSlot(slot);
--
2.43.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sahityajb@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Remove trailing period from errmsg in subscriptioncmds.c
In-Reply-To: <20260308142806.181309-1-sahityajb@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox