public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yugo Nagata <[email protected]>
To: Dean Rasheed <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: Allow to collect statistics on virtual generated columns
Date: Fri, 3 Apr 2026 10:10:32 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEZATCVtSyr1eOmHT=8B4i=RqHHM6_vbhLJhJorU+F89MMpA-A@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEZATCV6=q0-5HFBMg4jFS-j1ZCwANhp1sLXBQZYsK2ZLwq0AQ@mail.gmail.com>
	<[email protected]>
	<CAEZATCUR5B=6M7H2bwRU0_6FrbSE8yHe_+9bTbRUdU=jE33yog@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEZATCWkQhG0fwz5Z34vn=LcKdCb3DGfomPPwcXL_qtKfEt5+w@mail.gmail.com>
	<[email protected]>
	<CAEZATCV5ZbGZzmqKPow9tsaVuE3vmTU4WwEq0wHrsM=QHBpUEQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEZATCXMxaMP68A9HjC0NtMtzCfVyvDiYjH-zOVLcLj5B1pFgg@mail.gmail.com>
	<[email protected]>
	<CAEZATCVtSyr1eOmHT=8B4i=RqHHM6_vbhLJhJorU+F89MMpA-A@mail.gmail.com>

On Wed, 1 Apr 2026 17:12:38 +0100
Dean Rasheed <[email protected]> wrote:

> On Tue, 31 Mar 2026 at 15:35, Yugo Nagata <[email protected]> wrote:
> >
> > Thank you for updating the patch. I am fine with that.
> >
> > One concern is that users might interpret "stored" as referring to
> > "stored generated columns", rather than including regular columns,
> 
> Yeah, possibly. I changed "stored" to "non-virtual", which should
> reduce the chances of that particular confusion.
> 
> > Also, the meaning of "automatically" might be a bit unclear, so we
> > could clarify it by adding "without defining extended statistics."
> >
> >       Defining extended statistics on a single <emphasis>stored</emphasis>
> >       column is not supported or necessary, because statistics are built
> >       automatically on such columns without defining extended statistics.
> 
> OK, pushed that way.

Thank you!

> 
> I also noticed that a few places in CreateStatistics() could use the
> variable "numcols" instead of "list_length(stmt->exprs)", so I changed
> that.
> 
> I decided to include the change to the error message discussed in [1],
> since there seemed to be a consensus there, except that I think it
> also needs to make it clear that it refers only to non-virtual
> columns.
> 
> In addition, there was another nearby error message which was no
> longer quite right for statistics on virtual generated columns, and I
> changed the order of checks, since that allowed the "if" statements to
> be simplified a bit.

I reviewed the commit, and it looks good to me.
Thanks again.

Regards,
Yugo Nagata


-- 
Yugo Nagata <[email protected]>

view thread (21+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Allow to collect statistics on virtual generated columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox