public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Wed, 27 May 2026 11:49:06 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAAe_zD7vCLCb+vxpO3P-NsDUZ=JcN8EGCV0dz0BNgBKsbOGcQ@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAAAe_zD7vCLCb+vxpO3P-NsDUZ=JcN8EGCV0dz0BNgBKsbOGcQ@mail.gmail.com>

Hi Henson,

> Thanks for catching this. I applied the patch and the RPR regress passes
> cleanly. I also re-ran it with debug_raw_expression_coverage_test turned
> on (on an assert-enabled build), and the full regress is green as well.
> 
> One observation while testing: the GUC catches missing case handlers
> once the walker actually reaches a node, but it cannot flag a missing
> WALK on its own -- if no caller drives the walker into a subtree, the
> omission stays silent. So your inspection was the part that found the
> gap; the GUC just confirms the patch closes it. With the patch in, RPR
> raw subtrees are on the safety net for any future node-type additions.

Thanks for checking.

> I'll include the patch in v48 as nocfbot-0015. My suggestion would
> be to defer the fold until the jian-response patches (numbered from
> 0016 onward, which I'll be sending shortly) have also gone through a
> review round, so the whole bundle can land together in one pass.
> Patch attached below for convenience.

Sure. I will wait for your ready-to-go signal before creating the v48
pach set.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox