public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Tue, 02 Jun 2026 14:23:56 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAAAe_zBi1dOtWb2vnwSvGwuU0-bqAOm_7dOM4u-CmukA8xaV5Q@mail.gmail.com>
<CAAAe_zAuHwqUfqJOD4PDUkWsxTfTytNaandq11Kddw2bfCcpvQ@mail.gmail.com>
<[email protected]>
Oops.
> While looking into 0002, I noticed some minor ereport calling style
> issues.
>
> Recently we start to use the style:
>
> ereport(ERROR,
> errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>
> Rather than (old style):
>
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>
> Grepping patches shows following results that hire the old style.
>
> $ grep -n '(errcode' *|grep '+'
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1243:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1248:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1421:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1428:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1451:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1457:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1463:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1471:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1494:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1504:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
These have been fixed in 0007. Sorry for noise.
Maybe this is the only one worth to look into?
> nocfbot-0025-Reject-single-row-window-frame-in-row-pattern-rec.txt:55:+ (errcode(ERRCODE_WINDOWING_ERROR),
Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
view thread (109+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Row pattern recognition
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox