public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH] Fix loose polling in 019_replslot_limit.pl test
Date: Mon, 08 Jun 2026 13:18:41 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hello.

At Sat,  6 Jun 2026 21:32:22 +0100, Zakariyah Ali <[email protected]> wrote in 
> -git a/src/test/recovery/t/019_replslot_limit.pl b/src/test/recovery/t/019_replslot_limit.pl
> index a412faf51c6..3fdce739965 100644
> --- a/src/test/recovery/t/019_replslot_limit.pl
> +++ b/src/test/recovery/t/019_replslot_limit.pl
> @@ -186,18 +186,9 @@ $node_primary->advanc


(Some explanation of the motivation would be helpful.)

These are test scripts, so unless there is some functional issue with
the existing code, I'm not sure we should actively replace existing
implementations with wait_for_log(). In other words, I would normally
expect this kind of change to happen only when the surrounding code is
being modified for some functional reason.

As for this patch specifically, there are still other places using
open-coded log searches (for example, 033_replay_tsp_drops.pl). If we
decide to make this kind of change, I think it would make more sense
to update similar cases together.

Regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix loose polling in 019_replslot_limit.pl test
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox