public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint
Date: Wed, 10 Jun 2026 13:53:35 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAMm1aWbCX_Tso1s1oBh6g3=sdvDdZX68gMAN8KRv9Z-1ykiu8w@mail.gmail.com>
References: <[email protected]>
	<adX97VrD4pJKF8zt@MAC-CVW1VHW5R6>
	<CAMm1aWbCX_Tso1s1oBh6g3=sdvDdZX68gMAN8KRv9Z-1ykiu8w@mail.gmail.com>

I tend to agree with Michael on the meaning of minRecoveryPoint.

If a tool is using minRecoveryPoint to determine how far recovery has
progressed, then I would say it is looking at the wrong value. I also
do not quite understand what such a tool is trying to verify by
comparing minRecoveryPoint with the recovery target LSN.

If the goal is to verify that recovery reached the configured target,
PostgreSQL already performs that check itself and exits with a FATAL
error otherwise:

>  ereport(FATAL,
>     (errcode(ERRCODE_CONFIG_FILE_ERROR),
>      errmsg("recovery ended before configured recovery target was reached")));

If the underlying use case were explained in more detail, we could
probably have a more concrete discussion about how to address
it. However, I do not think changing the semantics of minRecoveryPoint
is the right solution based on the information available so far.

Regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (491+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox