public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nitin Jadhav <[email protected]>
To: Adam Lee <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint
Date: Tue, 9 Jun 2026 18:08:36 +0530
Message-ID: <CAMm1aWbCX_Tso1s1oBh6g3=sdvDdZX68gMAN8KRv9Z-1ykiu8w@mail.gmail.com> (raw)
In-Reply-To: <adX97VrD4pJKF8zt@MAC-CVW1VHW5R6>
References: <aczc9cxkr7SEHXV5@MAC-CVW1VHW5R6>
	<[email protected]>
	<acz_NsifcL_IzMjn@MAC-CVW1VHW5R6>
	<ac9LsF7bL6UW75VM@MAC-CVW1VHW5R6>
	<[email protected]>
	<adX97VrD4pJKF8zt@MAC-CVW1VHW5R6>

Hi Adam, Michael,

I went through the discussion and wanted to share my thoughts.

I agree with Michael's point that semantically, minRecoveryPoint
represents the minimum LSN needed for on-disk page consistency, and
from that strict perspective, the current behavior is technically
correct. However, I also acknowledge Adam's concern about the
practical impact on tooling and automation that relies on
pg_controldata to accurately reflect recovery progress.

Given that the current behavior creates inconsistency across
recovery_target_action settings (pause and promote behave differently
than shutdown), external tools such as pg_rewind, backup solutions,
and monitoring systems depend on this value for operational decisions,
I support moving forward with this patch.

Regarding Michael's point about simplifying the minRecoveryPoint
update logic—I completely agree that reducing code paths and
complexity in this area would be valuable. If there are specific areas
that could benefit from simplification or refactoring, I would be
interested in helping with that work.

I haven't reviewed the patch in detail yet, but I will do so and share
any feedback or comments.

Best Regards,
Nitin Jadhav
Azure Database for PostgreSQL
Microsoft

view thread (495+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint
  In-Reply-To: <CAMm1aWbCX_Tso1s1oBh6g3=sdvDdZX68gMAN8KRv9Z-1ykiu8w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox