agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Noah Misch <noah@leadboat.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Subject: Re: Collation & ctype method table, and extension hooks
Date: Mon, 29 Jun 2026 18:29:19 -0700
Message-ID: <20260630012919.78@rfd.leadboat.com> (raw)
In-Reply-To: <5c3c03133ea4d4e575690360d891e4e0921780bd.camel@j-davis.com>
References: <dfff1ca84dd0e8ee03aa2478412134895b0b9681.camel@j-davis.com>
<247f18f3-09e5-480d-9222-9d0d9684995f@proxel.se>
<78a1b434ff40510dc5aaabe986299a09f4da90cf.camel@j-davis.com>
<4548a168-62cd-457b-8d06-9ba7b985c477@proxel.se>
<7aa46d77b377428058403723440862d12a8a129a.camel@j-davis.com>
<54771b2aa90f0c09085ce3f97d7f07ddce47da55.camel@j-davis.com>
<679b689354bc4cd394bac850c7a03454d3412c0b.camel@j-davis.com>
<1c1b254807813bb708802d5f766ea97e7f06b265.camel@j-davis.com>
<cb580fec46ea4ca96dd4bbde9d2769360e097d01.camel@j-davis.com>
<5c3c03133ea4d4e575690360d891e4e0921780bd.camel@j-davis.com>
On Wed, Jun 11, 2025 at 10:49:17PM -0700, Jeff Davis wrote:
> Attached v16.
> I plan to commit this soon after branching.
> Subject: [PATCH v16 1/4] Control ctype behavior internally with a method
> table.
>
> Previously, pattern matching and case mapping behavior branched based
> on the provider.
>
> Refactor to use a method table, which is less error-prone and easier
> to hook.
This became refactor commit 5a38104. In a UTF8 database, the commit changed
the behavior of:
SELECT 'café' ILIKE 'caf_' COLLATE "C";
That query reports true in v18, false in v19. I've copied Claude's whole
review for the commit to
https://docs.google.com/document/d/19_xKpKUQlY5N51qbfXyipXs3rqIYEC3qk5oaUDJ48YA/edit?tab=t.0.
Two of its other findings sound potentially important, but I didn't verify
them.
nm
view thread (24+ messages) latest in thread
Message-ID: <20260630012919.78@rfd.leadboat.com>
Permalink: ../20260630012919.78@rfd.leadboat.com/
Also on: postgresql.org/message-id/20260630012919.78@rfd.leadboat.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, pgsql@j-davis.com, andreas@proxel.se, peter@eisentraut.org
Subject: Re: Collation & ctype method table, and extension hooks
In-Reply-To: <20260630012919.78@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox