public inbox for [email protected]  
help / color / mirror / Atom feed
From: Noah Misch <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: SPLIT/MERGE use of is_internal=true
Date: Wed, 8 Jul 2026 15:50:24 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAPpHfdu05sNB4M2N8Rq4ov_G3fyaMRJnCwkmByzwP4YDS8pCSg@mail.gmail.com>
References: <[email protected]>
	<CAPpHfdsVnD=BNHFo37sUkMCBi5EpsSJA3DYRGn5rOSdpVonpuA@mail.gmail.com>
	<[email protected]>
	<CAPpHfdtjUedmH2cRr2ZWTEg-hofRauJHkQCh9i91_igt9nEWEQ@mail.gmail.com>
	<CAPpHfdu05sNB4M2N8Rq4ov_G3fyaMRJnCwkmByzwP4YDS8pCSg@mail.gmail.com>

On Wed, Jul 08, 2026 at 09:32:06PM +0300, Alexander Korotkov wrote:
> The attached patch removes is_internal = true from 3 other function

That covers all I saw.

> calls, and removes PERFORM_DELETION_INTERNAL flag from
> performDeletionCheck() (the flag in ignored, no functional effect but
> code consistency).  This is all I managed to find.  What do you think?

The patch looks good.  The PERFORM_DELETION_INTERNAL removals make sense to
me, too.






view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: SPLIT/MERGE use of is_internal=true
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox