public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: enable fallthrough warnings on clang
Date: Tue, 07 Apr 2026 10:35:27 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAGECzQTs7qXSs8ztAFHCN=KB8SA_zDxO8CZ5+zBwq7zVOXbKKg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Peter Eisentraut <[email protected]> writes:
> On 06.04.26 23:31, Tom Lane wrote:
>> BF member ayu is failing said test:
>> ...
>> I don't know if it's worth catering to this extremely old
>> clang version ...

> But AFAICT, clang 5 and older are completely broken in this regard, 
> because they react to the presence of [[clang::fallthrough]] with a 
> syntax error ("error: expected expression").  Not even clang's own 
> example code[0] works.

Hah, so we'd make it worse not better by adding
[[clang::fallthrough]].  Let's leave well enough alone then.

			regards, tom lane

view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: enable fallthrough warnings on clang
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox