pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tristan Partin <tristan@neon.tech>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@postgresql.org, Shlok Kyal <shlok.kyal.oss@gmail.com>
Subject: Re: psql not responding to SIGINT upon db reconnection
Date: Wed, 03 Apr 2024 10:31:40 -0400
Message-ID: <2049574.1712154700@sss.pgh.pa.us> (raw)
In-Reply-To: <CAGECzQRmbNRz4hQ8JhbopAZLgAg_cQyT+zPxq4u9-kEHXqyXJA@mail.gmail.com>
References: <CUAJJDVD8L61.2AH6VEEDMTXX3@gonk>
	<CUAKHCX5472I.SJP0AWQRYVFA@gonk>
	<CUAKIOVISECO.2S7MSQFOP1304@gonk>
	<1588058.1690220636@sss.pgh.pa.us>
	<CUAO24Z1Y72E.2069AD01EB4LO@gonk>
	<CANhcyEVBQWoPJK+C_h1CKyN3Wr2VKHuPx=bSB4PH2LuGdut4qg@mail.gmail.com>
	<CWRWDTTPP0WZ.2W75ZAVL5ND1M@neon.tech>
	<5e28b89f-0033-4e42-8184-b71b731c1aa2@iki.fi>
	<CX5IOLTR8MAD.1UUDEG0X673Z4@neon.tech>
	<9b3693b7-0bc3-430a-b43f-eae44e8a39b6@iki.fi>
	<CX5NSE8R07D8.9D8M8LBKP119@neon.tech>
	<032868e0-a530-4fc7-972c-af6f08950b7e@iki.fi>
	<CXBHH2O58HVA.JUP07AES8JVK@neon.tech>
	<CXGM82ZEGMR2.8EX2V7UBFIK3@neon.tech>
	<CA+TgmoYK1JCJUyrK==TBj7St1hhke5AOwXyrmDAs-pA_mmAwVw@mail.gmail.com>
	<CY93J05RFBUI.3VGP5PLTG4EWI@neon.tech>
	<CA+TgmoZb1Ojhw9numxWp8nCioh_wULxOcYCQ6Jwku4t_e43PkA@mail.gmail.com>
	<CYCWA43RK8AH.11BZB0P45NOD5@neon.tech>
	<CYSE2DQI20CH.19LUJSCFH0748@neon.tech>
	<CAGECzQTX=esZ+71gAcHGYDBnv65-RGH14xpiFvJytN0uvULzCA@mail.gmail.com>
	<CYT3BG48WV2H.25BS2RN173HG9@neon.tech>
	<CA+Tgmoa1Uaqnd_OnV=KrQ5qf3=wYv8JM=3SC1e_=0xo! 0o9KEjg@mail.gmail.com>
	<D00FXVDVQG85.1CBNG8IZ2XM8E@neon.tech>
	<CA+Tgmob4cu9CZA_LQsSzGqJrN2RKhVLdR1rAP-5L5AA9W8regg@mail.gmail.com>
	<D00KWJOWYJ7L.1DZ1LKH01N7WG@neon.tech>
	<CA+TgmoacHJ7R9cP4q=XG_AYFtAO-9BV4unK3WqAtSigtv71afg@mail.gmail.com>
	<D08WWCPVHKHN.3QELIKZJ2D9RZ@neon.tech>
	<CA+TgmoYxJT19tvPPq7=gyLT-BSh-hK=zzhSGpf+bE=Q-WNE8Pg@mail.gmail.com>
	<CAGECzQRmbNRz4hQ8JhbopAZLgAg_cQyT+zPxq4u9-kEHXqyXJA@mail.gmail.com>

Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> Looking at the committed version of this patch, the pg_unreachable
> calls seemed weird to me. 1 is actually incorrect, thus possibly
> resulting in undefined behaviour. And for the other call an imho
> better fix would be to remove the now 21 year unused enum variant,
> instead of introducing its only reference in the whole codebase.

If we do the latter, we will almost certainly get pushback from
distros who check for library ABI breaks.  I fear the comment
suggesting that we could remove it someday is too optimistic.

			regards, tom lane





view thread (43+ messages)  latest in thread

Message-ID: <2049574.1712154700@sss.pgh.pa.us>
Permalink:  ../2049574.1712154700@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2049574.1712154700@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, postgres@jeltef.nl, robertmhaas@gmail.com, tristan@neon.tech, hlinnaka@iki.fi, shlok.kyal.oss@gmail.com
  Subject: Re: psql not responding to SIGINT upon db reconnection
  In-Reply-To: <2049574.1712154700@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox