pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: Removing --disable-strong-random from the code
Date: Sun, 30 Dec 2018 11:56:48 -0500
Message-ID: <20532.1546189008@sss.pgh.pa.us> (raw)
In-Reply-To: <20186.1546188423@sss.pgh.pa.us>
References: <20181230063219.GG608@paquier.xyz>
	<23371.1546152342@sss.pgh.pa.us>
	<20181230071549.GA2734@paquier.xyz>
	<20181230143740.GB2734@paquier.xyz>
	<20186.1546188423@sss.pgh.pa.us>

I wrote:
> LGTM otherwise.

Oh, one more thought: the removal of the --disable-strong-random
documentation stanza means there's no explanation of what to do
to build on platforms without /dev/urandom.  Perhaps something
like this in installation.sgml:

      <para>
-      You need <productname>OpenSSL</productname>, if you want to support
-      encrypted client connections. The minimum required version is
-      0.9.8.
+      You need <productname>OpenSSL</productname> if you want to support
+      encrypted client connections.  <productname>OpenSSL</productname>
+      is also required for random number generation on platforms that
+      do not have <filename>/dev/urandom</filename> (except Windows).
+      The minimum required version is 0.9.8.
      </para>

			regards, tom lane




view thread (10+ messages)  latest in thread

Message-ID: <20532.1546189008@sss.pgh.pa.us>
Permalink:  ../20532.1546189008@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20532.1546189008@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, hlinnaka@iki.fi
  Subject: Re: Removing --disable-strong-random from the code
  In-Reply-To: <20532.1546189008@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox