From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: Hackers (PostgreSQL) <pgsql-hackers@postgresql.org>
Subject: Re: dblink patches for comment
Date: Wed, 27 May 2009 19:24:04 -0400
Message-ID: <20613.1243466644@sss.pgh.pa.us> (raw)
In-Reply-To: <4A1C9C8C.6030405@joeconway.com>
References: <4A1C9C8C.6030405@joeconway.com>
Joe Conway <mail@joeconway.com> writes:
> The attached addresses items#2 and 3 as listed by Bruce here:
> http://momjian.us/cgi-bin/pgsql/joe> I think it is consistent with the discussions we had a PGCon last week.
> Any objections to me committing this for 8.4?
It's hard to review it without any docs that say what it's supposed to do.
(And you'd need to patch the docs anyway, eh?)
> On a side note, should I try to address items #1 & #4 for 8.4 as well?
> Perhaps #4 yes since it is arguably a bug fix, but no to #1?
Yeah, my feeling too. #1 is a new feature that was submitted too late
for 8.4. I wouldn't have argued if you'd committed it anyway during
the commitfest, but it's definitely too late now. But #4 seems like
a bugfix.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, mail@joeconway.com
Subject: Re: dblink patches for comment
In-Reply-To: <20613.1243466644@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox