From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE .. ALTER COLUMN .. ERROR: attribute .. has wrong type
Date: Fri, 06 Jan 2017 15:08:05 -0500
Message-ID: <20691.1483733285@sss.pgh.pa.us> (raw)
In-Reply-To: <20170106194417.pkxd4nmkaqkrvz7j@alvherre.pgsql>
References: <20170106194417.pkxd4nmkaqkrvz7j@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Alvaro Herrera wrote:
>> Here's a first attempt at fixing this. It makes the test pass, but I
>> have the feeling that more complex ones might need more work.
> Here's another one with three main differences:
Hmm. The bespoke code for constructing the attno map bothers me;
surely there is existing code that does that? If not, it'd still
make more sense to factor it out, I think, because there will be
other needs for it in future.
Otherwise, this seems sound in terms of fixing the observed problem,
but what are the implications for event triggers exactly? Does a
trigger see only the original expression, or only the modified expression,
or ???
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pryzby@telsasoft.com, robertmhaas@gmail.com
Subject: Re: ALTER TABLE .. ALTER COLUMN .. ERROR: attribute .. has wrong type
In-Reply-To: <20691.1483733285@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox