From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: AIX support - alignment issues
Date: Tue, 05 Jul 2022 23:47:10 -0400
Message-ID: <2073146.1657079230@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJzapRb3UwJF-bLsv=-p6WLk4_hs6WxR8y9LFTSdJBOCw@mail.gmail.com>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
<CAH2-WzndKXQQGh-7sCOTKL_87Kt918r0F2ztTAraeBCAC8v3OQ@mail.gmail.com>
<968410.1656789743@sss.pgh.pa.us>
<CAH2-WzmnoGPN--Z7MfTqv2TTVLJF0Y0tzZbGUS-NAwJ0wv15hw@mail.gmail.com>
<977853.1656794075@sss.pgh.pa.us>
<CA+hUKGLo8XVq4c=QpXFO5i3t3u5q6Fope=QgRtE-S3RncP+aUg@mail.gmail.com>
<1415825.1656893299@sss.pgh.pa.us>
<CA+hUKGJg5kg7LSeKZm1cDFQCTLBWUF1wvuM4eebJBq9DwYfZYw@mail.gmail.com>
<1827177.1656996797@sss.pgh.pa.us>
<CA+hUKGJzapRb3UwJF-bLsv=-p6WLk4_hs6WxR8y9LFTSdJBOCw@mail.gmail.com>
Thomas Munro <thomas.munro@gmail.com> writes:
> OK, here's a new attempt, this time leaving the hppa bits in. The
> main tricksy bit is where s_lock.h is simplified a bit by moving the
> fully inline GCC-only hppa support up a bit (it was handled a bit
> weirdly with some #undef jiggery-pokery before to share stuff between
> aCC and GCC), making the diff a little hard to follow. Does this make
> sense? It might also be possible to drop one of __hppa and __hppa__
> where they are both tested (not clear to me if that is an aCC/GCC
> thing). I have no idea if this'll actually work (or ever worked) on
> NetBSD/hppa... if it comes to it I could try to boot it under
> qemu-system-hppa if that's what it takes, but it may be easy for you
> to test...
Our HEAD does work on that NetBSD installation. I can try this
patch, but it'll take an hour or two to get results ... stay tuned.
I'm not sure about the __hppa vs __hppa__ thing. If we're assuming
that NetBSD is the only remaining hppa platform of interest, then
clearly only one of those is needed, but I don't know which one
should be preferred. It appears that both are defined on NetBSD.
(FWIW, I know that OpenBSD works on this machine too, or did the
last time I tried it. But it probably has the same opinions
as NetBSD about predefined macros.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, pg@bowt.ie, andres@anarazel.de, noah@leadboat.com, robertmhaas@gmail.com
Subject: Re: AIX support - alignment issues
In-Reply-To: <2073146.1657079230@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox