From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Date: Thu, 16 May 2024 10:45:18 -0400
Message-ID: <2096381.1715870718@sss.pgh.pa.us> (raw)
In-Reply-To: <195c6c45-abce-4331-be6a-e87724e1d060@eisentraut.org>
References: <20240422192218.GB367217@nathanxps13>
<3154983.1713816488@sss.pgh.pa.us>
<20240422202010.GA420168@nathanxps13>
<20240423200455.GA850264@nathanxps13>
<CA+Tgmoacj1F=h6HQocSo7btsYDE7Sh+9Lz-g=uZpDMFUVMeCjQ@mail.gmail.com>
<20240515192952.GA1428991@nathanxps13>
<CA+TgmobNVBN=Ki=N_5s__T3fvvaD3ppawjEs6KrQB5jUXBL2pA@mail.gmail.com>
<1833482.1715804603@sss.pgh.pa.us>
<1919000.1715815925@sss.pgh.pa.us>
<195c6c45-abce-4331-be6a-e87724e1d060@eisentraut.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> In these cases, I think for
> NotificationHash
> ResourceOwnerData
> WalSyncMethod
> we can just get rid of the typedef.
I have no objection to dealing with NotificationHash as you have here.
> ReadBuffersFlags shouldn't be an enum at all, because its values are
> used as flag bits.
Yeah, that was bothering me too, but I went for the minimum delta.
I did think that a couple of integer macros would be a better idea,
so +1 for what you did here.
> WaitEventExtension, I'm not sure, it's like, an extensible enum? I
> guess let's remove the typedef there, too.
I am also quite confused by that. It seems to be kind of an enum
that is supposed to be extended at runtime, meaning that neither
of the existing enum member values ought to be used as such, although
either autoprewarm.c didn't get the memo or I misunderstand the
intended usage. NUM_BUILTIN_WAIT_EVENT_EXTENSION is possibly the
most bizarre idea I've ever seen: what would a "built-in extension"
event be exactly? I think the enum should be nuked altogether, but
it's a bit late to be redesigning that for v17 perhaps.
> Attached is a variant patch.
I'm good with this, with a mental note to look again at
WaitEventExtension later.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, robertmhaas@gmail.com, nathandbossart@gmail.com
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
In-Reply-To: <2096381.1715870718@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox