agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Antonin Houska <ah@cybertec.at>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: advanced partition matching algorithm for partition-wise join
Date: Thu, 07 Sep 2017 16:04:14 +0200
Message-ID: <2103.1504793054@localhost> (raw)
In-Reply-To: <CAFjFpRfdXpuSu0pxON3dKcr8WndJkaXLzHUVax_Laod0Tgc6UQ@mail.gmail.com>
References: <CAFjFpRdjQvaUEV5DJX3TW6pU5eq54NCkadtxHX2JiJG_GvbrCA@mail.gmail.com>
	<CAKcux6nqCb7+zJBEF=QQzzHOB9acf2rMU+L609eWnkLtkKb5Vw@mail.gmail.com>
	<CAFjFpReNYx3814Twfg5rMMwCaOo8fzSmyhNLT8QmcFOnwiTJBQ@mail.gmail.com>
	<CAKcux6kinAwQFbk9Ce5_04UdKhrRm+SvpM-Cwz_Zc2Yqja+CYQ@mail.gmail.com>
	<CAFjFpRfdXpuSu0pxON3dKcr8WndJkaXLzHUVax_Laod0Tgc6UQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote:

> I have fixed the issues which were marked as TODOs in the attached
> patches. Also, I have included your test change patch in my series of
> patches.

I've noticed that partition_bounds_merge() is called twice from
make_join_rel():

 * build_join_rel -> build_joinrel_partition_info -> partition_bounds_merge

 * try_partition_wise_join -> partition_bounds_merge

Is this intentional, or just a thinko?

-- 
Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt
Web: http://www.postgresql-support.de, http://www.cybertec.at


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (154+ messages)  latest in thread

Message-ID: <2103.1504793054@localhost>
Permalink:  ../2103.1504793054@localhost/
Also on:    postgresql.org/message-id/2103.1504793054@localhost

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at, ashutosh.bapat@enterprisedb.com
  Subject: Re: advanced partition matching algorithm for partition-wise join
  In-Reply-To: <2103.1504793054@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox