From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: SQL-standard function body
Date: Fri, 10 Jul 2020 13:24:21 -0400
Message-ID: <2106877.1594401861@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJVjEccyThK=5-n+F=2NtpYQwVpyi3GLNFqFxjjDwyXCQ@mail.gmail.com>
References: <1c11f1eb-f00c-43b7-799d-2d44132c02d7@2ndquadrant.com>
<CA+hUKGJVjEccyThK=5-n+F=2NtpYQwVpyi3GLNFqFxjjDwyXCQ@mail.gmail.com>
Thomas Munro <thomas.munro@gmail.com> writes:
> On Wed, Jul 1, 2020 at 5:49 AM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> - More test coverage is needed. Surprisingly, there wasn't actually any
>> test AFAICT that just creates and SQL function and runs it. Most of
>> that code is tested incidentally, but there is very little or no
>> targeted testing of this functionality.
> FYI cfbot showed a sign of some kind of error_context_stack corruption
> while running "DROP TABLE functest3 CASCADE;".
BTW, it occurs to me after answering bug #16534 that
contrib/earthdistance's SQL functions would be great candidates for this
new syntax. Binding their references at creation time is really exactly
what we want.
I still feel that we can't just replace the existing implementation,
though, as that would kill too many use-cases where late binding is
helpful.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, peter.eisentraut@2ndquadrant.com
Subject: Re: SQL-standard function body
In-Reply-To: <2106877.1594401861@sss.pgh.pa.us>
References: <1c11f1eb-f00c-43b7-799d-2d44132c02d7@2ndquadrant.com> <CA+hUKGJVjEccyThK=5-n+F=2NtpYQwVpyi3GLNFqFxjjDwyXCQ@mail.gmail.com> <2106877.1594401861@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox