public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: solaimurugan vellaipandiyan <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: Payal Singh <[email protected]>
Cc: [email protected]
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: Mon, 11 May 2026 12:42:40 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
=?utf-8?Q?=C3=81lvaro?= Herrera <[email protected]> writes:
> Just passing by, but I think this comment should be handled manually as
> well, as I doubt we want it to end up this way:
Hmmm ... yeah, probably. In isolation the diff had looked all right
to me, but it would probably make more sense to keep this comment
aligned with the surrounding code. I'm thinking like
}
/*-----
* limit (sum(1/i^2),i=1,inf) = pi^2/6
* resj = sum(wi/i^2),i=1,noccurrence,
* wi - should be sorted desc,
* don't sort for now, just choose maximum weight.
* This should be corrected
* Oleg Bartunov
*/
res = res + (wjm + resj - wjm / ((jm + 1) * (jm + 1))) / 1.64493406685;
> (Not that I understand what this is trying to tell me, mind)
Me either :-(
regards, tom lane
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox