public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: vignesh C <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Melanie Plageman <[email protected]>
Subject: Re: Relation bulk write facility
Date: Tue, 27 Feb 2024 15:45:45 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CA+hUKGKtVazR0yEDxOrZYAmeaVbvQxNXSb6K8BDYOtuRVnCMDQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+hUKGLAr9Rki58cNCdv_ivR5=Uyps5v-e-bEhHUK3gJTT7wtQ@mail.gmail.com>
	<CA+hUKGLuG2s4-+4DH+JDJh0CiSGU8SbGfK1ZXYWkMQS7iHdGxw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+Tgmoaoi6BioWTndnkRmMVxQ4QL=xF7Z_PC_8zwpreNshfnJQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>

Heikki Linnakangas <[email protected]> writes:
> What do y'all think of adding a check for 
> ALIGNOF_DOUBLE==MAXIMUM_ALIGNOF to configure.ac and meson.build? It's 
> not a requirement today, but I believe AIX was the only platform where 
> that was not true. With AIX gone, that combination won't be tested, and 
> we will probably break it sooner or later.

+1, and then probably revert the whole test addition of 79b716cfb7a.

I did a quick scrape of the buildfarm, and identified these as the
only animals reporting ALIGNOF_DOUBLE less than 8:

$ grep 'alignment of double' alignments  | grep -v ' 8$'
 hornet        | 2024-02-22 16:26:16 | checking alignment of double... 4
 lapwing       | 2024-02-27 12:40:15 | checking alignment of double... (cached) 4
 mandrill      | 2024-02-19 01:03:47 | checking alignment of double... 4
 sungazer      | 2024-02-21 00:22:48 | checking alignment of double... 4
 tern          | 2024-02-22 13:25:12 | checking alignment of double... 4

With AIX out of the picture, lapwing will be the only remaining
animal testing MAXALIGN less than 8.  That seems like a single
point of failure ... should we spin up another couple 32-bit
animals?  I had supposed that my faithful old PPC animal mamba
was helping to check this, but I see that under NetBSD it's
joined the ALIGNOF_DOUBLE==8 crowd.

			regards, tom lane

view thread (34+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Relation bulk write facility
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox