From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
Date: Wed, 21 Dec 2016 12:27:31 -0500
Message-ID: <21630.1482341251@sss.pgh.pa.us> (raw)
In-Reply-To: <dfa45c48-659c-caa8-76de-06006707c3aa@joeconway.com>
References: <19872.1482338965@sss.pgh.pa.us>
<dfa45c48-659c-caa8-76de-06006707c3aa@joeconway.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Joe Conway <mail@joeconway.com> writes:
> On 12/21/2016 08:49 AM, Tom Lane wrote:
>> I propose that we should change that string to "could not obtain message
>> string for error on connection "foo"", or something along that line.
>>
>> postgres_fdw has the same disease. It wouldn't have the notion of a named
>> connection, but maybe we could insert the foreign server name instead.
> Seems reasonable to me. I can work on it if you'd like. Do you think
> this should be backpatched?
If you have time for it, please do, I have lots on my plate already.
I'd vote for back-patching; the benefits of a clearer error message
are obvious, and it hardly seems likely that any existing applications
are depending on this specific error string.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, mail@joeconway.com
Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
In-Reply-To: <21630.1482341251@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox