pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Imai Yoshikazu <yoshikazu_i443@live.jp>
Cc: jesper.pedersen@redhat.com <jesper.pedersen@redhat.com>
Cc: Imai, Yoshikazu <imai.yoshikazu@jp.fujitsu.com>
Cc: 'Amit Langote' <amitlangote09@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: speeding up planning with partitions
Date: Fri, 22 Mar 2019 17:51:20 -0400
Message-ID: <21897.1553291480@sss.pgh.pa.us> (raw)
In-Reply-To: <20519.1553288822@sss.pgh.pa.us>
References: <CAKJS1f9XAePd2+8F4=wtHKdDdckgKcSoXb-ZbU8Wbt86mhLxKA@mail.gmail.com>
	<d768d90d-628e-6cdc-513d-f50a0ce02cea@redhat.com>
	<CA+HiwqFTqUVuiyK7dDQDCrNF1NiPDOAnmQum2jcw1yj5Z+kC0Q@mail.gmail.com>
	<0F97FA9ABBDBE54F91744A9B37151A5129DD55@g01jpexmbkw24>
	<256b9c87-b687-6f51-6274-19ae5743aef6@lab.ntt.co.jp>
	<0F97FA9ABBDBE54F91744A9B37151A5129E604@g01jpexmbkw24>
	<9feacaf6-ddb3-96dd-5b98-df5e927b1439@lab.ntt.co.jp>
	<0F97FA9ABBDBE54F91744A9B37151A512B3279@g01jpexmbkw24>
	<0c90ce90-b010-4791-41c0-a0df34f99ffa@lab.ntt.co.jp>
	<0F97FA9ABBDBE54F91744A9B37151A512B3528@g01jpexmbkw24>
	<d964510e-2eec-ce42-8ad8-884caf718e03@lab.ntt.co.jp>
	<0F97FA9ABBDBE54F91744A9B37151A512B359C@g01jpexmbkw24>
	<72094fc9-3232-0fc7-b7cd-42e1c73d5aee@lab.ntt.co.jp>
	<0F97FA9ABBDBE54F91744A9B37151A512B45CD@g01jpexmbkw24>
	<53a80692-c68d-5e11-1014-6441b6e8ca5a@redhat.com>
	<BYAPR20MB22790FAFA860B03602A9A7B4BC420@BYAPR20MB2279.namprd20.prod.outlook.com>
	<d04c7027-2df8-bbd5-9a8f-9806e3ab3270@lab.ntt.co.jp>
	<c8dcf0fd-! ! 4759-5e1c-ea67-e2d3f98e81bd@lab.ntt.co.jp>
	<20519.1553288822@sss.pgh.pa.us>

I wrote:
> ... I also
> don't like the undocumented way that you've got build_base_rel_tlists
> working on something that's not the final tlist, and then going back
> and doing more work of the same sort later.  I wonder whether we can
> postpone build_base_rel_tlists until after the other stuff happens,
> so that it can continue to do all of the tlist-distribution work.

On further reflection: we don't really need the full build_base_rel_tlists
pushups for these extra variables.  The existence of the original rowmark
variable will be sufficient, for example, to make sure that we don't
decide the parent partitioned table can be thrown away as a useless join.
All we need to do is add the new Var to the parent's reltarget and adjust
its attr_needed, and we can do that very late in query_planner.  So now
I'm thinking leave build_base_rel_tlists() where it is, and then fix up
the tlist/reltarget data on the fly when we discover that new child rels
need more rowmark types than we had before.  (This'd be another reason to
keep the tlist in root->processed_tlist throughout, likely.)

			regards, tom lane




view thread (265+ messages)  latest in thread

Message-ID: <21897.1553291480@sss.pgh.pa.us>
Permalink:  ../21897.1553291480@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21897.1553291480@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp, yoshikazu_i443@live.jp, jesper.pedersen@redhat.com, imai.yoshikazu@jp.fujitsu.com, amitlangote09@gmail.com, david.rowley@2ndquadrant.com, alvherre@2ndquadrant.com, robertmhaas@gmail.com, pryzby@telsasoft.com
  Subject: Re: speeding up planning with partitions
  In-Reply-To: <21897.1553291480@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox