pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Date: Mon, 16 Jan 2017 14:13:18 -0500
Message-ID: <21924.1484593998@sss.pgh.pa.us> (raw)
In-Reply-To: <20170116083316.2izqrxbvmyalazac@alap3.anarazel.de>
References: <20160912173815.dlew2xsblcso33sw@alap3.anarazel.de>
	<17324.1473716167@sss.pgh.pa.us>
	<20160912220705.b77smzorutebnbee@alap3.anarazel.de>
	<19682.1473719703@sss.pgh.pa.us>
	<20160912231144.f3nseocp274iq7wg@alap3.anarazel.de>
	<23413.1473723322@sss.pgh.pa.us>
	<20160912234630.caueobrrbg5vse5y@alap3.anarazel.de>
	<557.1473895705@sss.pgh.pa.us>
	<20161031160639.nyxoktszi5psl2cc@alap3.anarazel.de>
	<20170116032952.z2re55hcfhzbkmrm@alap3.anarazel.de>
	<20170116083316.2izqrxbvmyalazac@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> That worked quite well.  So we have a few questions, before I clean this
> up:

> - For now the node is named 'Srf' both internally and in explain - not
>   sure if we want to make that something longer/easier to understand for
>   others? Proposals? TargetFunctionScan? SetResult?

"Srf" is ugly as can be, and unintelligible.  SetResult might be OK.

> - I continued with the division of Labor that Tom had set up, so we're
>   creating one Srf node for each "nested" set of SRFs.  We'd discussed
>   nearby to change that for one node/path for all nested SRFs, partially
>   because of costing.  But I don't like the idea that much anymore. The
>   implementation seems cleaner (and probably faster) this way, and I
>   don't think nested targetlist SRFs are something worth optimizing
>   for.  Anybody wants to argue differently?

Not me.

> Comments?

Hard to comment on your other points without a patch to look at.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (110+ messages)  latest in thread

Message-ID: <21924.1484593998@sss.pgh.pa.us>
Permalink:  ../21924.1484593998@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21924.1484593998@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
  In-Reply-To: <21924.1484593998@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox