From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Cc: mikael.kjellstrom@gmail.com
Subject: Re: Race condition in crash-recovery tests
Date: Sat, 26 Jan 2019 21:45:11 -0500
Message-ID: <21941.1548557111@sss.pgh.pa.us> (raw)
In-Reply-To: <20190127022937.nvocrvsok7nlp4vt@alap3.anarazel.de>
References: <19344.1548554028@sss.pgh.pa.us>
<20190127022937.nvocrvsok7nlp4vt@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2019-01-26 20:53:48 -0500, Tom Lane wrote:
>> I have no idea why we're seeing this in only one buildfarm member
>> and only for the past week or so, as it doesn't appear that any
>> related code has changed for months. (Perhaps something changed
>> about curculio's host?)
> I have no idea why it's just curculio, but I think I know why it only
> started recently: Curculio doesn't appear to have tap tests enabled
> before
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=curculio&dt=2019-01-17%2021%3A30%3A02
Oh, right ... I knew that, actually, but forgot ...
So then we only have to assume that the race condition is encouraged
by something about the kernel scheduler's rules on that machine, which
isn't so much of a leap, especially since it's our only OpenBSD
critter. The test case only exists in v11 and HEAD branches, and
curculio's only run this test a few times in v11, so the lack of
back-branch failures isn't so odd.
>> just change the test script to accept either message as a successful
>> result. I think that 4247db625 made such races more likely, but I
>> don't believe it was impossible before.
> Sounds right to me - do you want to do the honors or shall I?
I'll do it in a bit.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, mikael.kjellstrom@gmail.com
Subject: Re: Race condition in crash-recovery tests
In-Reply-To: <21941.1548557111@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox