agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Mon, 16 Mar 2026 10:13:00 +0100
Message-ID: <22068.1773652380@localhost> (raw)
In-Reply-To: <8349.1773389498@localhost>
References: <202603121839.7ttist64mas5@alvherre.pgsql>
<8349.1773389498@localhost>
Antonin Houska <ah@cybertec.at> wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > - the name pgoutput_repack sounds wrong to me. I would rather say
> > rpck_output, repack_output, repack_plugin, ... or something. I don't
> > understand where the suffix "output" comes from in the name
> > "pgoutput", but it sounds like arbitrary nonsense to me.
>
> No strong preference here ...
One more problem related to the replication slot is that, due to the call of
CheckSlotPermissions() in setup_logical_decoding(), REPLICATION privilege is
required for REPACK (CONCURRENTLY) to run. That's not too user-friendly.
I think the reason to require the REPLICATION privilege is that, in generic
case, the output plugin can access data of any table in the database. However
REPACK uses one particular plugin and that plugin only decodes changes of one
particular table. Thus I think we don't really need to call
CheckSlotPermissions(). Do I seem to miss something?
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <22068.1773652380@localhost>
Permalink: ../22068.1773652380@localhost/
Also on: postgresql.org/message-id/22068.1773652380@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, alvherre@alvh.no-ip.org, mihailnikalayeu@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <22068.1773652380@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox