pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Default setting for enable_hashagg_disk
Date: Sat, 11 Jul 2020 10:27:02 -0400
Message-ID: <2210835.1594477622@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvqDFEX2LTaBuX3SJd6NcPd-3-ZeVs7ijBU=Ej-4fPZLww@mail.gmail.com>
References: <20200708140037.GI3125@tamriel.snowman.net>
	<99b047386525b87df1e611335c2e57a6cdef346b.camel@j-davis.com>
	<20200709140330.GO3125@tamriel.snowman.net>
	<CAH2-WzmB04dxgRgjDGvDbugEFfHxMi2pyuJqsYr30x1RAEqSXg@mail.gmail.com>
	<20200709225840.GE12375@tamriel.snowman.net>
	<CAH2-WzmbycnZnxFTYnwkSkCPTVQbRoLiuEvo8gkZCKiQTL8GAQ@mail.gmail.com>
	<20200710000842.GF12375@tamriel.snowman.net>
	<CAH2-Wz=9f-gxPmqL9Lak0xddPmH0bgfAEioK+2BwTkuzyrtZEQ@mail.gmail.com>
	<20200710141714.GI12375@tamriel.snowman.net>
	<CAH2-Wzkd7cWK-mMPMb63JXxj2QFMan6hw+cQjdJKvdtCOpR7Ng@mail.gmail.com>
	<20200710215012.GN12375@tamriel.snowman.net>
	<2165606.1594418399@sss.pgh.pa.us>
	<CAApHDvpD_q4wbSnzQJoKT+19uChxSkkw5t-Q2X--o-K8T2TCWQ@mail.gmail.com>
	<CAKFQuwa2gwLa0b+mQv5r5A_Q0XWsA2=1zQ+Z5m4pQprxh-aM4Q@mail.gmail.com>
	<CAApHDvpxbHHP566rRjJWgnfS0YOxR53EZTz5LHH-jcEKvqdj4g@mail.gmail.com>
	<CAH2-WzkABYexMiM2nwoViR0g0a+=cmFSp66gXZZmNYEDRaksbg@mail.gmail.com>
	<CAApHDvqDFEX2LTaBuX3SJd6NcPd-3-ZeVs7ijBU=Ej-4fPZLww@mail.gma! il.com>

David Rowley <dgrowleyml@gmail.com> writes:
> hmm yeah. It's unfortunate, but I'm not sure how I'd have implemented
> it differently.  The problem is made worse by the fact that we'll only
> release the memory for the hash table during ExecEndHashJoin(). If the
> planner had some ability to provide the executor with knowledge that
> the node would never be rescanned, then the executor could release the
> memory for the hash table after the join is complete.

EXEC_FLAG_REWIND seems to fit the bill already?

			regards, tom lane





view thread (218+ messages)  latest in thread

Message-ID: <2210835.1594477622@sss.pgh.pa.us>
Permalink:  ../2210835.1594477622@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2210835.1594477622@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, pg@bowt.ie, david.g.johnston@gmail.com, sfrost@snowman.net, pgsql@j-davis.com, alvherre@2ndquadrant.com, andres@anarazel.de, bruce@momjian.us, robertmhaas@gmail.com, pryzby@telsasoft.com, melanieplageman@gmail.com, tomas.vondra@2ndquadrant.com
  Subject: Re: Default setting for enable_hashagg_disk
  In-Reply-To: <2210835.1594477622@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox