From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Christoph Berg <christoph.berg@credativ.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date: Tue, 13 Nov 2018 17:27:17 -0500
Message-ID: <22230.1542148037@sss.pgh.pa.us> (raw)
In-Reply-To: <20181113215716.qsdhsg54dmg6kvdl@alap3.anarazel.de>
References: <20181113104005.GA32154@msg.credativ.de>
<20181113215716.qsdhsg54dmg6kvdl@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2018-11-13 11:40:05 +0100, Christoph Berg wrote:
>> While working on making extension modules built reproducibly, I
>> noticed that extra flags passed via COPT (notably -ffile-prefix-map)
>> do not get added to CXXFLAGS.
> PROFILE I can see, but COPT I'm less sure. The name suggests it's about
> C not C++. How about adding CXXOPT?
> Secondary question: Why aren't you using CFLAGS/CXXFLAGS for this?
COPT (and PROFILE) are handy for injecting additional flags manually;
they're even documented for that (cf installation.sgml, around line
1550).
I agree that CXXOPT would be a better idea than COPT for this.
Not sure about PROFILE. But we could inject the latter into both
flag sets and then document that if that's not what you want, use COPT.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, christoph.berg@credativ.de
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
In-Reply-To: <22230.1542148037@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox