From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: gcc -Wclobbered in PostgresMain
Date: Mon, 10 Jul 2023 12:17:19 -0400
Message-ID: <2231130.1689005839@sss.pgh.pa.us> (raw)
In-Reply-To: <1f8a7f29-b526-db35-5584-a078ca20c8e2@postgrespro.ru>
References: <2eda015b-7dff-47fd-d5e2-f1a9899b90a6@postgrespro.ru>
<1632266.1688829082@sss.pgh.pa.us>
<1f8a7f29-b526-db35-5584-a078ca20c8e2@postgrespro.ru>
Sergey Shinderuk <s.shinderuk@postgrespro.ru> writes:
> On 08.07.2023 18:11, Tom Lane wrote:
>> Having done that, it wouldn't really be necessary to mark these
>> as volatile. I kept that marking anyway for consistency with
>> send_ready_for_query, but perhaps we shouldn't?
> I don't know. Maybe marking them volatile is more future proof. Not sure.
Yeah, after sleeping on it, it seems best to have a policy that all
variables declared in that place are volatile. Even if there's no bug
now, not having volatile creates a risk of surprising behavior after
future changes. Pushed that way.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, s.shinderuk@postgrespro.ru
Subject: Re: gcc -Wclobbered in PostgresMain
In-Reply-To: <2231130.1689005839@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox