From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Header checking failures on LLVM-less machines
Date: Mon, 28 Jan 2019 22:19:32 -0500
Message-ID: <22407.1548731972@sss.pgh.pa.us> (raw)
In-Reply-To: <20190129013753.5pjlj6laswxjnkli@alap3.anarazel.de>
References: <19808.1548692361@sss.pgh.pa.us>
<31363.1548723082@sss.pgh.pa.us>
<20190129005553.tuydbrscrl454yqn@alap3.anarazel.de>
<510.1548724909@sss.pgh.pa.us>
<20190129013753.5pjlj6laswxjnkli@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> I don't think we are actually contradicting each other. The aim of that
> error was to prevent pieces of code that aren't conditional on
> --with-llvm from including llvmjit.h. I was, for a moment and wrongly,
> thinking that we could style the header in a way that'd make it both for
> safe for cpluspluscheck and still error in that case, but that was a
> brainfart. But even leaving that brainfart aside, I'm not arguing
> against adding those include guards, so ...?
Works for me now. Thanks for fixing.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Header checking failures on LLVM-less machines
In-Reply-To: <22407.1548731972@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox