public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Andrew Dunstan <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: pgindent vs variable declaration across multiple lines
Date: Tue, 24 Jan 2023 10:33:35 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CA+hUKGLcernAWgMaZrkr123LuR8xdvOBz8TXYLXjjzthJkm5gA@mail.gmail.com>
	<[email protected]>
	<[email protected]>

Andrew Dunstan <[email protected]> writes:
> On 2023-01-22 Su 17:34, Tom Lane wrote:
>> I've also attached a diff
>> representing the delta between what current pg_bsd_indent wants to do
>> to HEAD and what this would do.  All the changes it wants to make look
>> good, although I can't say whether there are other places it's failing
>> to change that we'd like it to.

> Changes look good. There are a handful of places where I think the code
> would be slightly more readable if a leading typecast were moved to the
> second line.

Possibly, but that's the sort of decision that pgindent leaves to human
judgment I think.  It'll reflow comment blocks across lines, but I don't
recall having seen it move line breaks within code.

			regards, tom lane

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgindent vs variable declaration across multiple lines
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox