agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Antonin Houska <ah@cybertec.at>
To: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Wed, 01 Apr 2026 19:06:53 +0200
Message-ID: <224730.1775063213@localhost> (raw)
In-Reply-To: <CAFC+b6qJ3vE4zAHn7Q6MA2dixwYcY+K1iEMYhQYH01-Pr9XAjw@mail.gmail.com>
References: <202603311523.iqhng5ljkzpq@alvherre.pgsql>
	<202603311934.ftqj7ytm362y@alvherre.pgsql>
	<CAFC+b6qJ3vE4zAHn7Q6MA2dixwYcY+K1iEMYhQYH01-Pr9XAjw@mail.gmail.com>

Srinath Reddy Sadipiralla <srinath2133@gmail.com> wrote:

> i was fuzz testing v48 , and found a crash when REPACK (concurrently) itself errors out,
> 1) while running
> 
> create table test(id int);
> REPACK (concurrently) test;
> 
> TBH i didn't knew this, sometimes it's better to not know "rules" ;)
> [NOTE: maybe we should add that we can't run
> REPACK (concurrently) on table without identity index or primary key into repack.sgml]
> 
> ERROR:  cannot process relation "test"
> 2026-04-01 19:06:31.211 IST [2495575] HINT:  Relation "test" has no identity index.
> 2026-04-01 19:06:31.211 IST [2495575] STATEMENT:  repack (concurrently) test;
> TRAP: failed Assert("proc->statusFlags == ProcGlobal->statusFlags[proc->pgxactoff]"), File: "procarray.c", Line: 719, PID: 2495575
> Here's the diff to solve this crash.

Thanks. Attached here is v48-0006 fixed.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Attachments:

  [text/x-diff] nocfbot.Error-out-any-process-that-would-block-at-REPACK.patch (0B, ../224730.1775063213@localhost/2-nocfbot.Error-out-any-process-that-would-block-at-REPACK.patch)
  download

view thread (416+ messages)  latest in thread

Message-ID: <224730.1775063213@localhost>
Permalink:  ../224730.1775063213@localhost/
Also on:    postgresql.org/message-id/224730.1775063213@localhost

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at, srinath2133@gmail.com, alvherre@alvh.no-ip.org, amit.kapila16@gmail.com, mihailnikalayeu@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
  Subject: Re: Adding REPACK [concurrently]
  In-Reply-To: <224730.1775063213@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox