pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Jim Nasby <Jim.Nasby@bluetreble.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Speed up Clog Access by increasing CLOG buffers
Date: Fri, 10 Mar 2017 01:21:28 -0500
Message-ID: <22895.1489126888@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1KAteYXb-KRY=tBRcM=D20o5UvgHePxpwRaBS7eqrkBaQ@mail.gmail.com>
References: <CAA4eK1+8=X9mSNeVeHg_NqMsOR-XKsjuqrYzQf=iCsdh3U4EOA@mail.gmail.com>
	<acf46406-cf6d-41fe-4118-4e1c960b4790@2ndquadrant.com>
	<CAFiTN-tCqDucbikxue0x0dwNOAa6yzjMxJNgXGQm90jVVRSj0Q@mail.gmail.com>
	<CAFiTN-t15PjFTFQH0fBfM5jVSv6rfm5J_8vj=RGuKeFpdLgSoQ@mail.gmail.com>
	<CAA4eK1LyR2A+m=RBSZ6rcPEwJ=rVi1ADPSndXHZdjn56yqO6Vg@mail.gmail.com>
	<4a52a34f-57fa-7bcf-d34c-c15db40f0361@2ndquadrant.com>
	<CAA4eK1KTbNbZSDo=6k4YgaJh_FM20zJCKu2Yt0bxaFMv9QcSXQ@mail.gmail.com>
	<b3586234-6c80-5b64-1261-871e0e852bbb@2ndquadrant.com>
	<956b695d-f6c5-d652-bf0c-cea95981547c@BlueTreble.com>
	<f769dd83-6288-2c37-4958-b7ddad0bc974@2ndquadrant.com>
	<5275bf49-545e-e189-48c5-17b5defc45a2@2ndquadrant.com>
	<CA+TgmobmDLM1dzFvN_tJoBunarMpz+cehx1cVfv-QMKk4rZLPQ@mail.gmail.com>
	<ca714e28-81a2-440c-bd92-79fe1fa0fc15@2ndquadrant.com>
	<CAA4eK1JjatUZu0+HCi=5VM1q-hFgN_OhegPAwEUJqxf-7pESbg@mail.gmail.com>
	<04e39ac9-af28-0fda-8f72-7268197d281f@2ndquadrant.com>
	<84c22fbb-b9c4-a02f-384b-b4feb2c67193@2ndquadrant.com>
	<CAA4eK1KAysCmBaYGbFXyu0wGTZuMWeNgYBHNd3goNrfD0-G2CA@mail.gmail.com>
	<CAFiTN-tTazysx8GvDFgNvCh17J9AbGM=XgD6PftkoWVCMUSsXQ@mail.gmail.com>
	<CAA4eK1J+67edo_Wnrfx8oJ+rWM_BAr+v6JqvQjKPdLOxR=0d5g@mail.gmail.com>
	<CAFiTN-sSp=UkeXezHnapuaLCNWmmAgzuYVEODbOwj5K2zbgWng@mail.gmail.com>
	<CAFiTN-tZbtsbAx1Wrsmqd7Z8weTOTpCt9sqikj3wXapVEcw-eA@mail.gmail.com>
	<CAA4eK1L9WHYTJY8KUq_+yzVMp1ep1UqB+b3x3Kb6hTVEUWascA@mail.gmail.com>
	<CAB7nPqTYT8oWXxmudwFbLxK7rJWU73LcJz3J+nCfVGvKE31NAQ@mail.gmail.com>
	<CA+TgmobgWHcXDcChX2+BqJDk2dkPVF85ZrJFhUyHHQmw8diTpA@mail.gmail.com>
	<9010.1489112253@sss.pgh.pa.us>
	<CA+TgmobrMF8ALx_7pGM+4G=i-o3NBf+FrB4bh6XHqUF7NuVgDA@mail.gmail.com>
	<20807.1489123260@sss.pgh.pa.us>
	<CAA4eK1KAteYXb-KRY=tBRcM=D20o5UvgHePxpwRaBS7eqrkBaQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Amit Kapila <amit.kapila16@gmail.com> writes:
> Just to let you know that I think I have figured out the reason of
> failure.  If we run the regressions with attached patch, it will make
> the regression tests fail consistently in same way.  The patch just
> makes all transaction status updates to go via group clog update
> mechanism.

This does *not* give me a warm fuzzy feeling that this patch was
ready to commit.  Or even that it was tested to the claimed degree.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (248+ messages)  latest in thread

Message-ID: <22895.1489126888@sss.pgh.pa.us>
Permalink:  ../22895.1489126888@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/22895.1489126888@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, robertmhaas@gmail.com, michael.paquier@gmail.com, dilipbalaut@gmail.com, tomas.vondra@2ndquadrant.com, Jim.Nasby@bluetreble.com, andres@anarazel.de
  Subject: Re: Speed up Clog Access by increasing CLOG buffers
  In-Reply-To: <22895.1489126888@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox