From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: New "-b slim" option in 2019b zic: should we turn that on?
Date: Sat, 05 Oct 2019 18:33:13 -0400
Message-ID: <23096.1570314793@sss.pgh.pa.us> (raw)
In-Reply-To: <e93f047e-6c31-7a1e-b723-4418d756d9b1@2ndQuadrant.com>
References: <24998.1563403327@sss.pgh.pa.us>
<e93f047e-6c31-7a1e-b723-4418d756d9b1@2ndQuadrant.com>
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> I've just run into an issue with this (commit a1207910968). The makefile
> now assumes that zic has this switch. But I was attempting to get around
> an issue on msys2 by using its zic, (ZIC=/usr/bin/zic configure ...). It
> crashes on the floor because it doesn't know about "-b slim". I think we
> probably need a way to turn this off.
I had contemplated injecting the -b switch via
# any custom options you might want to pass to zic while installing data files
-ZIC_OPTIONS =
+ZIC_OPTIONS = -b slim
which would allow overriding it by defining the ZIC_OPTIONS macro.
Does that seem appropriate? I didn't do it because I worried about
interference with existing uses of ZIC_OPTIONS ... but who knows
whether there are any.
BTW, building with old versions of zic is not guaranteed to work anyway.
They do tend to wait a year or two before they start to use new zic
features in the timezone data files, but they don't wait indefinitely.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: New "-b slim" option in 2019b zic: should we turn that on?
In-Reply-To: <23096.1570314793@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox