pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PQgetssl() and alternative SSL implementations
Date: Tue, 19 Aug 2014 19:11:46 -0400
Message-ID: <23201.1408489906@sss.pgh.pa.us> (raw)
In-Reply-To: <20140819223103.GA20476@awork2.anarazel.de>
References: <53F1E989.8020609@vmware.com>
	<CA+TgmoZDJ6CKiuBMqNk3iS7LQ9GZuzS7RTYSOvRu8kJjRKWLng@mail.gmail.com>
	<CABUevExpTZpMAMvr=BkeO5-XG_zgZP=TKdyCCpgEpYc0Htjr8Q@mail.gmail.com>
	<10419.1408475397@sss.pgh.pa.us>
	<CABUevEy03OvP3N3wBRVP7BcmwcHf=Qi6Crb2MHo4dVmG--ZnVg@mail.gmail.com>
	<CA+TgmoaKHd+HW8kOgzovdSTWhauEsV0qeRsxPLpEZfSNDiSP=g@mail.gmail.com>
	<53F3C87E.2080401@vmware.com>
	<20140819223103.GA20476@awork2.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-08-20 00:58:22 +0300, Heikki Linnakangas wrote:
>> I don't much like adding a separate function for every SSL implementation,
>> but you've got a point that it would be nice to make it difficult to call
>> PQgetSSLstruct() and just assume that the returned struct is e.g an OpenSSL
>> struct, while it's actually something else. Perhaps:

> A good reason to not have functions with the respective functions is
> that it requires either including the relevant headers or adding forward
> declarations of the libraries type.

It requires no such thing.  What we do for PQgetssl() is declare it as
returning "void *", and we could easily do the same for other libraries.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (44+ messages)  latest in thread

Message-ID: <23201.1408489906@sss.pgh.pa.us>
Permalink:  ../23201.1408489906@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23201.1408489906@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@2ndquadrant.com, hlinnakangas@vmware.com, robertmhaas@gmail.com, magnus@hagander.net
  Subject: Re: PQgetssl() and alternative SSL implementations
  In-Reply-To: <23201.1408489906@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox