public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Peter Geoghegan <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: John Naylor <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: A qsort template
Date: Thu, 19 May 2022 18:43:41 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAH2-WzkNY8F0WNXkUUKPVS_Dh0LDiYOHmuh1sbuAX2DK0nBBTg@mail.gmail.com>
References: <[email protected]>
<CA+hUKGLvvAiHy9AHPUWFR1uLskATvqkofjD7nxgcPtJD1tdojQ@mail.gmail.com>
<CA+hUKGJRbzaAOUtBUcjF5hLtaSHnJUqXmtiaLEoi53zeWSizeA@mail.gmail.com>
<CAApHDvoO0sJiGgqK3vx=XX4TF6qik3YbLT-XAfvQLW6uq=t-NQ@mail.gmail.com>
<CAFBsxsEJxfQcMfCjGi+Vbkqf0SnpCW65vfh4SMySYo8NaBTLhg@mail.gmail.com>
<CAApHDvqWQJrAwLBveQLTfcB46NSer7qRLTe_NJF2cPuXziu4oA@mail.gmail.com>
<CAFBsxsH4RGpNB+O17FKnYApOmo0h+434iis+-9G6S3-p-krpOA@mail.gmail.com>
<CAFBsxsEVzWYhjpXfoBKOGro--dfy9Xb5O_qU_hikHrYoOjsysg@mail.gmail.com>
<CAApHDvr8bhkgsdOxhUUngX5n72UkJ6NTjprSGthX_CX1KWxZPg@mail.gmail.com>
<CAFBsxsHOUf6pDZOXpHTfV1H_TwLDaKGfRwhAWO=BL53sfTgt9w@mail.gmail.com>
<[email protected]>
<CAH2-WzkNY8F0WNXkUUKPVS_Dh0LDiYOHmuh1sbuAX2DK0nBBTg@mail.gmail.com>
Peter Geoghegan <[email protected]> writes:
> On Thu, May 19, 2022 at 1:12 PM Justin Pryzby <[email protected]> wrote:
>> Should these debug lines be removed ?
>>
>> elog(DEBUG1, "qsort_tuple");
> I agree -- DEBUG1 seems too chatty for something like this. DEBUG2
> would be more appropriate IMV. Though I don't feel very strongly about
> it.
Given the lack of context identification, I'd put the usefulness of
these in production at close to zero. +1 for removing them
altogether, or failing that, downgrade to DEBUG5 or so.
regards, tom lane
view thread (78+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: A qsort template
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox