pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Tomas Vondra <tomas.vondra@postgresql.org>
Cc: Peter Smith <smithpb2250@gmail.com>
Subject: Re: shadow variables - pg15 edition
Date: Wed, 05 Oct 2022 10:19:21 -0400
Message-ID: <2321227.1664979561@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvqWGMdB_pATeUqE=JCtNqNxObPOJ00jFEa2_sZ20j_Wvg@mail.gmail.com>
References: <20220819042816.GU26426@telsasoft.com>
	<CAApHDvrwLGBP+Yw9vriayyf=XR4uPWP5jr6cQhP9au_kaDUhbA@mail.gmail.com>
	<20220823011659.GF2342@telsasoft.com>
	<CAApHDvovE675zPvqiY6Y9pV1X53jSGjyhkf75yc8WGy7qAGdEA@mail.gmail.com>
	<20220823021412.GG2342@telsasoft.com>
	<CAApHDvoSgT93Da5D=ZWWhsE_exGyjK6sGWt5LpFJHsnaXVELzw@mail.gmail.com>
	<20220824023944.GM2342@telsasoft.com>
	<CAApHDvpL3ZpRhSaLf7wqSAbF42RtnJ_7puyiXR=2RdkoZ9RsjQ@mail.gmail.com>
	<20220830054441.GF31833@telsasoft.com>
	<CAApHDvq4dg7M+_imHZJ3bxNRW53EBkDuo6jxmSnMtrtX_Br3fQ@mail.gmail.com>
	<20221004023012.GT7745@telsasoft.com>
	<CAApHDvoRsphHHznoBAsPaQEDvFka7W0ONm8mwXx6x6Zs0h+FmA@mail.gmail.com>
	<CAApHDvqWGMdB_pATeUqE=JCtNqNxObPOJ00jFEa2_sZ20j_Wvg@mail.gmail.com>

David Rowley <dgrowleyml@gmail.com> writes:
> I've attached a draft patch for a method I was considering to fix the
> warnings we're getting from the nested PG_TRY() statement in
> utility.c.

+1

> The only warning remaining after applying the attached is the "now"
> warning in pgbench.c:7509.  I'd considered changing this to "thenow"
> which translates to "right now" in the part of Scotland that I'm from.
> I also considered "nownow", which is used in South Africa [1].
> Anyway, I'm not really being serious, but I didn't come up with
> anything better than "now2".

Yeah, "now2" seems as reasonable as anything.

			regards, tom lane





view thread (56+ messages)  latest in thread

Message-ID: <2321227.1664979561@sss.pgh.pa.us>
Permalink:  ../2321227.1664979561@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2321227.1664979561@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, pryzby@telsasoft.com, tomas.vondra@postgresql.org, smithpb2250@gmail.com
  Subject: Re: shadow variables - pg15 edition
  In-Reply-To: <2321227.1664979561@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox