public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Robert Treat <[email protected]>
Cc: Shinya Kato <[email protected]>
Cc: Yugo Nagata <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
Date: Fri, 17 Jan 2025 15:11:10 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABV9wwM4vzO2BYDgw0N9Yd6TTrmrvT+eLrSfWE2z7Ra3CQtdXA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwbnNfH0RYcDnwYkhbXi_VK+yKHaMGvRP9J1vFrLHnze0w@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZ8H9erEpDXO=ucgSLbMJfutZf+d=WQXWoJiB2ziD_Xpg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CABV9wwM4vzO2BYDgw0N9Yd6TTrmrvT+eLrSfWE2z7Ra3CQtdXA@mail.gmail.com>

Robert Treat <[email protected]> writes:
> suggested diffs attached, let me know if you would like a consolidated patch

Sadly, the cfbot is now confused since it doesn't understand the idea
of an incremental patch.  Somebody please post a consolidated patch.

For myself, I'd suggest writing the examples with -X not --no-psqlrc.
-X is shorter, it's more likely to be what people would actually
type, and it's not jarringly inconsistent with the adjacent use
of -h and other short-form switches.  We can write the added
paragraphs like 

   It is generally recommended to use the <option>-X</option>
   (<option>--no-psqlrc</option>) option when restoring a database ...

to provide clarity about what the switch does.

			regards, tom lane






view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox