From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Retiring support for pre-7.3 FK constraint triggers
Date: Thu, 05 Mar 2020 15:50:29 -0500
Message-ID: <23394.1583441429@sss.pgh.pa.us> (raw)
In-Reply-To: <20200305183656.GA24065@alvherre.pgsql>
References: <20200305183656.GA24065@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Mar-05, Tom Lane wrote:
>> As long as we're thinking of zapping code that is long past its sell-by
>> date, I propose getting rid of this stanza in indexcmds.c, which
>> basically causes CREATE INDEX to ignore certain opclass specifications:
> I agree, this should be fine to remove.
Done.
>> which dates to 8.2 (2a8d3d83e of 2005-11-07). This is less bad than the
>> other thing, since it won't affect the behavior of any command that
>> wouldn't otherwise just fail; but maybe its time has passed as well?
>> Although Alvaro's point comparing these behaviors to pg_dump's support
>> cutoff of 8.0 suggests that maybe we should leave this one for now.
> Yeah, dunno, 'rtree' is even immortalized in tests; commit f2e403803fe6
> as recently as March 2019 was seen modifying that.
Hah, I didn't realize we actually had code coverage for that!
> I guess we can wait a couple years more on that one, since it's not
> damaging anything anyway.
Agreed, I left it be.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: Retiring support for pre-7.3 FK constraint triggers
In-Reply-To: <23394.1583441429@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox