From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Fetter <david@fetter.org>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Synchronize with imath upstream
Date: Wed, 06 Feb 2019 10:15:24 -0500
Message-ID: <23413.1549466124@sss.pgh.pa.us> (raw)
In-Reply-To: <FB934CD7-B508-4523-B920-F0EE9CCB1756@anarazel.de>
References: <20190205234750.GA2774@alvherre.pgsql>
<FB934CD7-B508-4523-B920-F0EE9CCB1756@anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On February 6, 2019 5:17:50 AM GMT+05:30, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> I'm -1 for this myself. I think there are a few places that could
>> benefit from it, but my fear is that many *more* places would get
>> worse.
> Because of imported code like ryu and imath? And because it can make code considerably better when used judiciously.
I don't object to keeping imported code in a form that matches upstream
as best we can. (Should we also exclude such files from pgindent'ing?)
But changing conventions for our own code is an entirely different matter.
In this case, I think that having some places use it while the bulk of
the code doesn't is just a bad idea from a stylistic-consistency
standpoint. It's pretty much the same reason why we still aren't allowing
// comments --- there's no toolchain-based reason not to, but a mishmash of
comment styles would be ugly and hard to read.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@2ndquadrant.com, david@fetter.org, andrew@tao11.riddles.org.uk, noah@leadboat.com
Subject: Re: Synchronize with imath upstream
In-Reply-To: <23413.1549466124@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox