pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: Variable substitution in psql backtick expansion
Date: Sun, 12 Nov 2017 15:21:45 -0500
Message-ID: <23434.1510518105@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFj8pRAGwaZnDPPt5WqKw8wjgGBYDw2Zss+wBf5P-Mb9w2-NWw@mail.gmail.com>
References: <bc15034d-b421-42ac-89b1-c3485fa1728b@manitou-mail.org>
	<alpine.DEB.2.20.1704021805550.4632@lancre>
	<CADkLM=c+hm2rc0tkKgC-ZgrLttHT2KkfppE+BC-=i-xj+7V-TQ@mail.gmail.com>
	<3926.1491159242@sss.pgh.pa.us>
	<alpine.DEB.2.20.1704022151080.9265@lancre>
	<CAFj8pRDyaC+FaSxd92CLcuV+UFGhwY7NVVBhqFvxPkhvKNhyww@mail.gmail.com>
	<alpine.DEB.2.20.1705211737030.6053@lancre>
	<CA+TgmobT3rD6jaZMCs=PWH_khMu6Bb4TwX+r4tbTNA41hx32=w@mail.gmail.com>
	<13303.1503698976@sss.pgh.pa.us>
	<CA+TgmobXCcEM7uB8_g+tKfB-1gvEyp+Qmmre9bcXU9mgpmW38Q@mail.gmail.com>
	<14596.1503701034@sss.pgh.pa.us>
	<alpine.DEB.2.20.1708260747110.3627@lancre>
	<20786.1503760136@sss.pgh.pa.us>
	<alpine.DEB.2.20.1708261740590.17521@lancre>
	<24850.1503766425@sss.pgh.pa.us>
	<alpine.DEB.2.20.1708261959560.27500@lancre>
	<4959.1503774468@sss.pgh.pa.us>
	<alpine.DEB.2.20.1708270811060.18068@lancre>
	<2947.1504542679@sss.pgh.pa.us>
	<14258.1504557328@sss.pgh.pa.us>
	<alpine.DEB.2.20.1709042237230.19424@lancre>
	<CAFj8pRAGwaZnDPPt5WqKw8wjgG! BYDw2Zss+wBf5P-Mb9w2-NWw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Pavel Stehule <pavel.stehule@gmail.com> writes:
> [ psql-server-version-2.patch	]

I think this patch should be rejected.  It adds no new functionality;
you can get the string in question with "select version()".  Moreover,
you've been able to do that for lo these many years.  Any application
that tried to depend on this new way of getting the string would fail
when working with an older server or older psql.  That does not seem
like a good property for a version check.  Also, because the string
isn't especially machine-friendly, it's not very clear to me what the
use-case is for an application to use it at all, rather than the other
version formats we already provide.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (96+ messages)  latest in thread

Message-ID: <23434.1510518105@sss.pgh.pa.us>
Permalink:  ../23434.1510518105@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23434.1510518105@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pavel.stehule@gmail.com, coelho@cri.ensmp.fr, robertmhaas@gmail.com, corey.huinker@gmail.com, daniel@manitou-mail.org
  Subject: Re: Variable substitution in psql backtick expansion
  In-Reply-To: <23434.1510518105@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox