public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: John Naylor <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tristan Partin <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add BF member koel-like indentation checks to SanityCheck CI
Date: Wed, 10 Jan 2024 01:25:36 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANWCAZa6zO8FNzDCXdMBwwBo0csvWCcOJ12Np-11G42VPUTk4g@mail.gmail.com>
References: <CALj2ACWMupLTuD+bWfr2oBsNDpFJiuFaCK17S3Ty0YJbywdSfA@mail.gmail.com>
	<CANWCAZZObZeN9VqgmMY+mk4F1kpkuj=JB65R+o_HHoFT8c+eKg@mail.gmail.com>
	<[email protected]>
	<CANWCAZa6zO8FNzDCXdMBwwBo0csvWCcOJ12Np-11G42VPUTk4g@mail.gmail.com>

John Naylor <[email protected]> writes:
> Off the top of my head, I like to use '//' comments as quick notes to
> myself that stand out from normal code comments, and I'm in the habit
> of putting debug print statements flush against the left margin so
> they're really obvious. Both of these would be wiped out by pgindent.

+1.  I do both of those things, partly because pgindent would reformat
them so that it'd be obvious if I forgot to remove them.  (Yes, I
look at the diffs pgindent wants to make...)

So that leads to the conclusion that I wouldn't want an automatic
pgindent check to happen during "make all" or "make check", because
I want those things to succeed before I consider pgindent'ing.
Maybe it's okay to include it as part of check-world, but I'm
not quite sure about that either.

			regards, tom lane

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add BF member koel-like indentation checks to SanityCheck CI
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox