pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Use -fvisibility=hidden for shared libraries
Date: Sun, 17 Jul 2022 16:06:28 -0400
Message-ID: <234827.1658088388@sss.pgh.pa.us> (raw)
In-Reply-To: <20220717200041.6um6dmvxujtljm6q@awork3.anarazel.de>
References: <20211101020311.av6hphdl6xbjbuif@alap3.anarazel.de>
	<b8103d16bf26cff7a393d1de690474dbd9afaa19.camel@cybertec.at>
	<20211101054700.z3jzmc5lnxlad4y7@alap3.anarazel.de>
	<2499085.1641859296@sss.pgh.pa.us>
	<20220111025328.iq5g6uck53j5qtin@alap3.anarazel.de>
	<5b8d48a4-2fee-6764-7eda-a076f544ea33@enterprisedb.com>
	<20220716201750.qq6xwegkgp7xqi5w@awork3.anarazel.de>
	<180138.1658084088@sss.pgh.pa.us>
	<20220717200041.6um6dmvxujtljm6q@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> That's also the reason -fvisibility=hidden isn't added to libpq and the ecpg
> libs - their symbol visility is done via exports.txt. Depending on the
> platform that'd not work if symbols were already hidden via
> -fvisibility=hidden (unless explicitly exported via PGDLLEXPORT, of
> course).

Got it.  Yeah, let's not break those cases.  (I don't think we dare put
PGDLLEXPORT into libpq-fe.h, for example, so it might be hard to solve
it any other way anyhow.)

>> 2. I'm not really thrilled with the symbol names C[XX]FLAGS_SL_MOD;
>> it's not apparent what the MOD means, nor is that documented anywhere.

> It's for module, which I got from pgxs' MODULES/MODULE_big (and incidentally
> that's also what meson calls it). Definitely should be explained, and perhaps
> be expanded to MODULE.

I guessed as much, but +1 for spelling it out as MODULE.

			regards, tom lane





view thread (23+ messages)  latest in thread

Message-ID: <234827.1658088388@sss.pgh.pa.us>
Permalink:  ../234827.1658088388@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/234827.1658088388@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@enterprisedb.com, laurenz.albe@cybertec.at
  Subject: Re: Use -fvisibility=hidden for shared libraries
  In-Reply-To: <234827.1658088388@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox