public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Junwang Zhao <[email protected]>
Cc: jian he <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
Date: Fri, 20 Sep 2024 00:38:16 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CACJufxH0RxsxUQnAT2AVG08JFpA3C60L91_cEMM8JQd8P=12ow@mail.gmail.com>
	<[email protected]>
	<CACJufxEqJyD0o6t9f1NLp2cgaUeyRzNv+PiDuKnrP1xekHFYyQ@mail.gmail.com>
	<CACJufxEF9_o_tZeNg+rDV5MfQW6eYTdM9MUcy0Z5-VMWvf-tOw@mail.gmail.com>
	<CAEG8a3KQyeNvezSS3M3qAHykaDV9uPvTDp9i9+g+GvvDS4W7ug@mail.gmail.com>
	<[email protected]>

Michael Paquier <[email protected]> writes:
> On Fri, Sep 20, 2024 at 11:51:49AM +0800, Junwang Zhao wrote:
>> Should you also bump the catalog version?

> No need to worry about that when sending a patch because committers
> take care of that when merging a patch into the tree.  Doing that in
> each patch submitted just creates more conflicts and work for patch
> authors because they'd need to recolve conflicts each time a
> catversion bump happens.  And that can happen on a daily basis
> sometimes depending on what is committed.

Right.  Sometimes the committer forgets to do that :-(, which is
not great but it's not normally a big problem either.  We've concluded
it's better to err in that direction than impose additional work
on patch submitters.

If you feel concerned about the point, best practice is to include a
mention that catversion bump is needed in your draft commit message.

			regards, tom lane

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox