From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Postgres perl module namespace
Date: Mon, 18 Apr 2022 13:43:52 -0400
Message-ID: <2361941.1650303832@sss.pgh.pa.us> (raw)
In-Reply-To: <d74da58b-cfee-4fea-a31a-439921c0feb0@dunslane.net>
References: <da8a9278-3366-4871-4823-b929b3b5e91a@dunslane.net>
<YTWiXYixl/bM0Gft@paquier.xyz>
<780f82bb-3a25-0c6f-154a-9f24b9324dba@dunslane.net>
<615a96e7-6f8c-7bfb-216c-3ed0d619c04a@dunslane.net>
<2bb5f5b2-5210-5c98-2be6-405283d6f817@xs4all.nl>
<YW+LkgkbLkq7tdyf@paquier.xyz>
<a1c22c37-316c-7c57-abcf-99ee9cda80e4@dunslane.net>
<072a3088-7988-1c49-4d30-df47cf8e6415@dunslane.net>
<YXZm2CYR5Z3H9IWL@paquier.xyz>
<20220418141530.nfxtkohefvwnzncl@alap3.anarazel.de>
<20220418155224.GA1149931@rfd.leadboat.com>
<d74da58b-cfee-4fea-a31a-439921c0feb0@dunslane.net>
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2022-04-18 Mo 11:52, Noah Misch wrote:
>> On Mon, Apr 18, 2022 at 07:15:30AM -0700, Andres Freund wrote:
>>> I just, again, tried to backport a test as part of a bugfix. The
>>> renaming between 14 and 15 makes that task almost comically harder. The
>>> only way I see of dealing with that for the next 5 years is to just
>>> never backpatch tests to < 15. Which seems like a bad outcome.
> I'm not sure how often we do things like that. But I don't agree it's
> impossibly hard, although I can see it might be a bit annoying.
I think we back-patch test cases *all the time*. So I think Andres
is quite right to be concerned about making that harder, although I'm
not sure that his estimate of the conversion difficulty is accurate.
I plan to keep a copy of Noah's script and see if applying that to
the patch files alleviates the pain. In a few months we should have
a better idea of whether that's sufficient, or we want to go to the
work of back-patching the renaming.
I doubt that just plopping the new Cluster.pm in alongside the old
file could work --- wouldn't the two modules need to share state
somehow?
Another thing that ought to be on the table is back-patching
549ec201d (Replace Test::More plans with done_testing). Those
test counts are an even huger pain for back-patching than the
renaming, because the count is often different in each branch.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, noah@leadboat.com, andres@anarazel.de, michael@paquier.xyz, er@xs4all.nl, robertmhaas@gmail.com, alvherre@alvh.no-ip.org, mark.dilger@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres perl module namespace
In-Reply-To: <2361941.1650303832@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox