From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: PL_stashcache, or, what's our minimum Perl version?
Date: Mon, 31 Jul 2017 18:54:06 -0400
Message-ID: <23764.1501541646@sss.pgh.pa.us> (raw)
In-Reply-To: <6257.1501523593@sss.pgh.pa.us>
References: <20540.1501210115@sss.pgh.pa.us>
<16894.1501392088@sss.pgh.pa.us>
<20170730154814.GA2636941@rfd.leadboat.com>
<6257.1501523593@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> Done. I have also reconfigured buildfarm member prairiedog to use
> a non-MULTIPLICITY build of Perl 5.8.3, with the oldest Test::More
> and IPC::Run versions I could lay my hands on. Although I'd gotten
> through a manual "make check-world" with this configuration in HEAD
> before touching the buildfarm configuration, I see that it just fell
> over in the back branches. So there's still some more fixing to be
> done, or else we'll need to change that claim again. Will investigate
> once the buildfarm run finishes.
The reason it works manually and not in the buildfarm is that the
buildfarm injects
my $pflags = "PROVE_FLAGS=--timer";
(run_build.pl:1609) and it turns out that 5.8.3's version of prove
does not have the --timer switch. I see that --timer is there in
the next oldest version I have at hand, 5.8.6. I doubt it is worth
teaching the buildfarm scripts to autoconfigure this, but could we
do something like
my $pflags = "PROVE_FLAGS='" . ($ENV{PROVE_FLAGS} || "--timer") . "'";
to allow overriding this choice from the buildfarm config?
FYI, I plan to keep the TAP tests enabled on prairiedog for HEAD,
but probably not for the back branches after this run cycle
finishes, because it's just too-darn-slow.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, noah@leadboat.com
Subject: Re: PL_stashcache, or, what's our minimum Perl version?
In-Reply-To: <23764.1501541646@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox