pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nikolay Shaplov <dhyan@nataraj.su>
To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: [PATCH] check for ctags utility in make_ctags
Date: Mon, 31 Dec 2018 19:04:08 +0300
Message-ID: <2394207.ccz7JgCJsh@x200m> (raw)

Hi!

I'd like to propose a small patch for make_ctags script. It checks if ctags 
utility is intalled or not. If not it reports an error and advises to install 
ctags.

This will make life of a person that uses ctags first time in his life a bit 
easier.

I use command -v to detect if ctags command exists. It is POSIX standard and I 
hope it exist in all shells.

Attachments:


check-for-ctags-in-make_ctags.diff (text/x-patch, 386B) download
diff --git a/src/tools/make_ctags b/src/tools/make_ctags
index 1609c07..edbcd82 100755
--- a/src/tools/make_ctags
+++ b/src/tools/make_ctags
@@ -2,6 +2,13 @@
 
 # src/tools/make_ctags
 
+if [ ! $(command -v ctags) ]
+then
+  echo "'ctags' utility is not found" &1>2
+  echo "Please install 'ctags' to run make_ctags" &1>2
+  exit 1
+fi
+
 trap "rm -f /tmp/$$" 0 1 2 3 15
 rm -f ./tags
 

view thread (14+ messages)  latest in thread

Message-ID: <2394207.ccz7JgCJsh@x200m>
Permalink:  ../2394207.ccz7JgCJsh@x200m/
Also on:    postgresql.org/message-id/2394207.ccz7JgCJsh@x200m

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org
  Subject: Re: [PATCH] check for ctags utility in make_ctags
  In-Reply-To: <2394207.ccz7JgCJsh@x200m>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox