From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, Greg Stark <greg.stark@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Subject: Re: [SPAM] Re: posix_fadvise v22
Date: Sat, 10 Jan 2009 13:51:05 -0500
Message-ID: <24021.1231613465@sss.pgh.pa.us> (raw)
In-Reply-To: <4961C80C.6030307@gmx.net>
References: <FDDBA24E-FF4D-4654-BA75-692B3BA71B97@enterprisedb.com>
<603c8f070901012011hca2c36flf527a5cd01695205@mail.gmail.com>
<262184F8-1206-4E2C-B50F-9FF84E63C1B6@enterprisedb.com>
<200901032342.19435.peter_e@gmx.net>
<87iqowt3ba.fsf@oxford.xeocode.com>
<4961C80C.6030307@gmx.net>
Peter Eisentraut <peter_e@gmx.net> writes:
> The way I read this is that this was a temporary kernel/libc mismatch in
> a development version of Debian 3 years ago that was fixed within 2
> months of being reported and was never released to the general public.
> So it would be on the same level as any of a million temporary breakages
> in Linux distributions under development.
This is incorrect, as the problem was in fact present on Red Hat and
presumably all other distros as well.
> Unless there are other reports of this problem, I wouldn't bother
> testing or working around this at all. If people are running PostgreSQL
> 8.4+ on Debian unstable June 2005 with kernel 2.4, they cannot be helped.
While I would like to agree with that position, I can't help noticing
lines 2438-2461 of xlog.c, which represent the still-smoking wreckage of
our last attempt to do something with posix_fadvise. It's not that old
either --- we gave up on it less than three years ago:
http://archives.postgresql.org/pgsql-hackers/2006-06/msg01481.php
I think at a minimum there should be a manual configuration switch
(ie something in pg_config_manual.h) to allow the builder to disable
use of posix_fadvise, even if configure thinks it's there. Depending
on buildfarm results we may have to do more than that.
BTW, I intend to un-disable the xlog change when committing the fadvise
patch. In for a penny, in for a pound ...
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter_e@gmx.net, stark@enterprisedb.com, greg.stark@enterprisedb.com, robertmhaas@gmail.com, itagaki.takahiro@oss.ntt.co.jp
Subject: Re: [SPAM] Re: posix_fadvise v22
In-Reply-To: <24021.1231613465@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox