pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>
Subject: Re: Performance improvements for src/port/snprintf.c
Date: Wed, 03 Oct 2018 13:40:03 -0400
Message-ID: <2435.1538588403@sss.pgh.pa.us> (raw)
In-Reply-To: <20181003173639.tncawup2nnkp7vbv@alap3.anarazel.de>
References: <20181003060936.zul7mfkcu5w7rotg@alap3.anarazel.de>
	<25583.1538569214@sss.pgh.pa.us>
	<20181003155207.b3lqmovuv2c5c4id@alap3.anarazel.de>
	<26510.1538582852@sss.pgh.pa.us>
	<20181003161454.ozeioucsimjg5g6m@alap3.anarazel.de>
	<27041.1538583733@sss.pgh.pa.us>
	<20181003163717.oycshpp2hnctvtfj@alap3.anarazel.de>
	<28321.1538585692@sss.pgh.pa.us>
	<20181003170043.thdyezozi343dkuc@alap3.anarazel.de>
	<2132.1538587869@sss.pgh.pa.us>
	<20181003173639.tncawup2nnkp7vbv@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-10-03 13:31:09 -0400, Tom Lane wrote:
>> I do not see the point of messing with snprintf.c here.  I doubt that
>> strfromd is faster than the existing sprintf call (because the latter
>> can use ".*" instead of serializing and deserializing the precision).

> I'm confused, the numbers I posted clearly show that it's faster?

Those were in the context of whether float8out went through snprintf.c
or directly to strfromd, no?

			regards, tom lane

view thread (65+ messages)  latest in thread

Message-ID: <2435.1538588403@sss.pgh.pa.us>
Permalink:  ../2435.1538588403@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2435.1538588403@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@enterprisedb.com, andrew@tao11.riddles.org.uk, a.kuzmenkov@postgrespro.ru
  Subject: Re: Performance improvements for src/port/snprintf.c
  In-Reply-To: <2435.1538588403@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox