From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Subject: Re: Command Triggers, patch v11
Date: Sun, 18 Mar 2012 21:16:26 -0400
Message-ID: <24506.1332119786@sss.pgh.pa.us> (raw)
In-Reply-To: <1332107267.6915.2.camel@vanquo.pezone.net>
References: <m24nufq466.fsf@2ndQuadrant.fr>
<201203162237.38813.andres@anarazel.de>
<21818.1331934775@sss.pgh.pa.us>
<201203162317.43818.andres@anarazel.de>
<7094.1331996567@sss.pgh.pa.us>
<9503.1332006327@sss.pgh.pa.us>
<24814.1332021870@sss.pgh.pa.us>
<1332107267.6915.2.camel@vanquo.pezone.net>
Peter Eisentraut <peter_e@gmx.net> writes:
> On lör, 2012-03-17 at 18:04 -0400, Tom Lane wrote:
>> I'm not sure what we should do instead. We have gotten push-back before
>> anytime we changed the command tag for an existing command (and in fact
>> it seems that we intentionally added the rowcount display in 9.0, which
>> means there are people out there who care about that functionality).
>> On the other hand, the traditional output for CREATE TABLE AS doesn't
>> seem to satisfy the principle of least astonishment. A third
>> consideration is that if we are pushing CREATE TABLE AS as the preferred
>> spelling, people will probably complain if it omits functionality that
>> SELECT INTO provides; so I'm not sure that "SELECT n" in one case and
>> "CREATE TABLE AS" in the other would be a good idea either. Any
>> opinions what to do here?
> Another consideration is that the SQL command tags are defined by the
> SQL standard. So if we were to change it, then it should be "CREATE
> TABLE". I'm not convinced that it should be changed, though. (I recall
> cross-checking our list against the SQL standard in the past, so there
> might have been discussion on this already.)
If we were going to change the output at all, I would vote for "CREATE
TABLE nnnn" so as to preserve the rowcount functionality. Keep in mind
though that this would force client-side changes, for instance in
libpq's PQcmdTuples(). Fixing that one routine isn't so painful, but
what of other client-side libraries, not to mention applications?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter_e@gmx.net, andres@anarazel.de, thom@linux.com, dimitri@2ndquadrant.fr
Subject: Re: Command Triggers, patch v11
In-Reply-To: <24506.1332119786@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox