From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Remove support for Visual Studio 2013
Date: Thu, 26 May 2022 17:50:40 -0400
Message-ID: <2459697.1653601840@sss.pgh.pa.us> (raw)
In-Reply-To: <Yo/pw2D8MQutXmtR@paquier.xyz>
References: <YoH2IMtxcS3ncWn+@paquier.xyz>
<20220526154311.GA19626@telsasoft.com>
<Yo/pw2D8MQutXmtR@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, May 26, 2022 at 10:43:11AM -0500, Justin Pryzby wrote:
>> Maybe consider removing this workaround? The original problem report indicated
>> that it didn't affect later versions:
>>
>> src/backend/optimizer/path/costsize.c: /* This apparently-useless variable dodges a compiler bug in VS2013: */
> Hence reverting 3154e16. Sure!
+1
>> I'm not sure if it's worth removing this one, though:
>>
>> src/port/strtof.c: * On Windows, there's a slightly different problem: VS2013 has a strtof()
> Yeah.. I am not completely sure if all the patterns mentioned for
> VS2013 apply to Cygwin/Mingw, so keeping it around could be more
> beneficial.
The comments about that in win32_port.h and cygwin.h only date back
to 2019, so it seems unlikely that the situation has changed much.
We could try removing HAVE_BUGGY_STRTOF to see if the buildfarm
complains, but I wouldn't bet money on that succeeding. What we
*do* need to do is update the #if tests and comments to make clear
that HAVE_BUGGY_STRTOF is only needed for Mingw and Cygwin, not
for any supported MSVC release.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pryzby@telsasoft.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Remove support for Visual Studio 2013
In-Reply-To: <2459697.1653601840@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox